Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Currently Athena supports only a limited amount of auth methods depending on ASSUME_ROLE and OPTIONAL_CREDENTIALS flags values:
These scenarios do not cover cases when:
In this PR propose do not use ASSUME_ROLE and OPTIONAL_CREDENTIALS flags at all and use the same approach for all aws query runners, which allows to cover all possible scenarios:
aws_access_key_id and aws_secret_access_key are set and role_arn is not set - use static credentials for service client
aws_access_key_id, aws_secret_access_key and role_arn are all set - use static credentials for sts client and use assume role credentials for service client
only role_arn is set - use default credentials provider chain for sts client and assumed role credentials for service client
none is set - use default credentials provider chain for service client
Refactor
Feature
Bug Fix
New Query Runner (Data Source)
New Alert Destination
Other
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)